From: Duy Nguyen Date: Mon, 11 Jan 2016 00:50:40 GMT Subject: Re: [PATCH 3/3] builtin/grep: allow implicit --no-index Message-ID: In-Reply-To: <1452435597-12099-4-git-send-email-t.gummerer@gmail.com> On Sun, Jan 10, 2016 at 9:19 PM, Thomas Gummerer wrote: > Currently when git grep is used outside of a git repository without the > --no-index option git simply dies. For convenience, implicitly make git > grep behave like git grep --no-index when it is called outside of a git > repository. Should we have a line about this behavior in git-grep.txt, maybe the description section? I wonder if anybody wants the old behavior (e.g. non-zero exit code when running outside a repo). If there is such a case (*), we may need an option to revert it back (--no-no-index seems ridiculous, maybe --use-index). The safest way though, is introduce a new option like --use-index= then you can make an grep alias with --use-index=optional. (*) I've been hitting really weird real-world use cases so I'm a bit paranoid.. -- Duy