From: Duy Nguyen Date: Sun, 31 Mar 2013 01:35:39 GMT Subject: Re: [PATCH] branch: give better message when no names specified for rename Message-ID: In-Reply-To: <00E97900-F00D-455F-A3EB-52D0A3CF5CF6@JonathonMah.com> On Sun, Mar 31, 2013 at 8:27 AM, Jonathon Mah wrote: > - if (argc == 1) > + if (!argc) > + die(_("branch name required")); > + else if (argc == 1) > rename_branch(head, argv[0], rename > 1); > else if (argc == 2) > rename_branch(argv[0], argv[1], rename > 1); This makes four branches based on argc. Maybe we should convert if/else chain to switch/case. -- Duy