From: Duy Nguyen Date: Tue, 10 May 2016 12:57:41 GMT Subject: Re: [PATCH v9 00/19] index-helper/watchman Message-ID: In-Reply-To: On Tue, May 10, 2016 at 7:45 PM, Duy Nguyen wrote: > If --detach is used, log_warning() can't cover die(), > warning() or error(), most importantly die() for example because of > bugs. A case for redirecting warning() is because watchman-support.c uses it. But because this file is only used by index-helper, you have another option, simply convert it to using log_warning(). -- Duy