From: Duy Nguyen Date: Thu, 06 Oct 2016 05:48:37 GMT Subject: Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix Message-ID: In-Reply-To: On Thu, Oct 6, 2016 at 7:40 AM, Jacob Keller wrote: > On Wed, Oct 5, 2016 at 3:15 PM, Junio C Hamano wrote: >> SZEDER Gábor writes: >> >>> Gut feeling tells me that I should take this as a subtle >>> encouragement to look into adding 'versionsort.postreleasesuffix', >>> shouldn't I ;) >> >> It is more like "this made me realize that these are merely 'suffix' >> after the real release name, no pre- or post- about them", also >> known as "I think PREreleasesuffix was a mistake and we weren't >> thinking clearly enough when we added it." >> >> To me, this looks like a list of possible suffixes that can include >> an empty suffix to denote "the real thing", e.g. >> >> versionsort.suffix = "-alpha" "-beta" "" "-gamma" "-delta" >> >> and that position in the list determines the order of things inside >> the same family of versions that share the same "non-suffix" part. > > This is what makes sense to me. Perhaps migrade to "releasesuffix" and > deprecate "prereleasesuffix"? Even though this is mostly used with tag listing, it can be used with branch listing and general refs as well, where "release" does not really make sense. So I prefer the name versionsort.suffix to versionsort.releasesuffix. > I don't think that's too painful > especially if git accepts the old value and warns about it's > deprecation? That or we can just stick with calling it pre-release and > they sort based on order with '' being the empty value? Yeah deprecation is good, we don't want to support to config keys with different algorithms forever. -- Duy