From: Duy Nguyen <pclouds@gmail.com>
Date: Wed, 26 Mar 2014 23:15:15 GMT
Subject: Re: [PATCH v2 06/17] ls-files: add --color to highlight file names
Message-ID: <CACsJy8BjWVJu=_xyey=oBfCgemVBU4p98b+w0PaUQbFk0HG3Hw@mail.gmail.com>
In-Reply-To: <CAPig+cTMRHi2sWQLZzdHZGWT6GBX-3v8exx8B4jpWm0Tgvg6+Q@mail.gmail.com>

On Thu, Mar 27, 2014 at 2:13 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Wed, Mar 26, 2014 at 9:48 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>>  Documentation/git-ls-files.txt |  9 +++++++++
>>  builtin/ls-files.c             | 38 +++++++++++++++++++++++++++++++++++---
>>  2 files changed, 44 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt
>> index c0856a6..5c1b7f3 100644
>> --- a/Documentation/git-ls-files.txt
>> +++ b/Documentation/git-ls-files.txt
>> @@ -147,6 +147,15 @@ a space) at the start of each line:
>>         possible for manual inspection; the exact format may change at
>>         any time.
>>
>> +--color[=<when>]::
>> +       Color file names. The value must be always (default), never,
>> +       or auto.
>
> Here, the default is "always"...

These (.txt changes in other patches as well) are mostly copy and
paste from existing .txt files. You may want to grep through and fix
other places as well, in a separate series.

>
>> +--no-color::
>> +       Turn off coloring, even when the configuration file gives the
>> +       default to color output, same as `--color=never`. This is the
>> +       default.
>
> But, here the default is "never".

What I mean is color is turned off by default for ls-files (in
contrast, ls has color on by default). The default 'always' means that
if you write --color without the <when> part, then it's
--color=always. How do I phrase to make it clear?
-- 
Duy