From: Duy Nguyen <pclouds@gmail.com>
Date: Sun, 05 Apr 2015 14:36:04 GMT
Subject: Re: [PATCH 3/6] strbuf_getwholeline: use getc_unlocked
Message-ID: <CACsJy8Biv6D2foDxpn-CZhEsjn3WsPV=_A3UOnT4+1LVrpRnTw@mail.gmail.com>
In-Reply-To: <20150405045614.GA12053@peff.net>

On Sun, Apr 5, 2015 at 11:56 AM, Jeff King <peff@peff.net> wrote:
> So we'd have to either:
>
>   1. Decide that doesn't matter.
>
>   2. Have callers specify a "damn the NULs, I want it fast" flag.

2+. Avoid FILE* interface and go with syscalls for reading
packed-refs? If mmaping the entire file could be a problem for some
platform because it's too large, we have code for reading (with
bufferring) from fd somewhere, e.g. index-pack.

>   3. Find some alternative that is more robust than fgets, and faster
>      than getc. I don't think there is anything in stdio, but I am not
>      above dropping in a faster non-portable call if it is available,
>      and then falling back to the current code otherwise.
-- 
Duy