From: Nguyen Thai Ngoc Duy Date: Fri, 10 Feb 2012 04:43:23 GMT Subject: Re: What's cooking in git.git (Jan 2012, #08; Tue, 31) Message-ID: In-Reply-To: <7vhayzs51s.fsf@alter.siamese.dyndns.org> 2012/2/10 Junio C Hamano : > Junio C Hamano writes: > >> It turns out that this series, as a side effect, fixes a long-standing bug >> that the --branch option cannot be used with the --mirror option. >> >> I am tempted to merge it also to 1.7.9.1 maintenance track. The issue is >> minor (you can always clone with --mirror and then switch the branch with >> "checkout") and it does not look like it warrants further backpointing to >> 1.7.8 and older releases, though. >> >> Comments and/or objections? No objections. Does it fix a failed test? If not, should we add a test to record this side effect fix? > Replying to myself. > > Regardless of "'refs/heads/$branch' is not found because we do not look > for in the right place" issue, shouldn't the use of the --mirror without > the --bare option forbidden or at least warned about? --mirror implies --bare in cmd_clone() if I read it correctly. -- Duy