From: Duy Nguyen Date: Mon, 07 Nov 2016 09:38:24 GMT Subject: Re: [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange Message-ID: In-Reply-To: (sorry I got sick in the last few weeks and could not respond to this earlier) On Mon, Nov 7, 2016 at 4:44 AM, Christian Couder wrote: > Le 6 nov. 2016 09:16, "Junio C Hamano" a écrit : >> >> Christian Couder writes: >> >> > I think it is easier for user to be able to just set core.splitIndex >> > to true to enable split-index. >> >> You can have that exact benefit by making core.splitIndex to >> bool-or-more. If your default is 20%, take 'true' as if the user >> specified 20% and take 'false' as if the user specified 100% (or is >> it 0%? I do not care about the details but you get the point). > > Then if we ever add 'auto' and the user wants for example 10% instead of the > default 20%, we will have to make it accept things like "auto,10". In my opinion, "true" _is_ auto, which is a way to say "I trust you to do the right thing, just re-split the index when it makes sense", "no" is disabled of course. If the user wants to be specific, just write "10" or some other percentage.(and either 0 or 100 would mean enable split-index but do not re-split automatically, let _me_ do it when I want it) -- Duy