From: Duy Nguyen <pclouds@gmail.com>
Date: Sat, 05 Dec 2015 05:48:44 GMT
Subject: Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when ..
Message-ID: <CACsJy8BXy03EMLRcXNKnkAj_kxreEVZYRVRTqNz2EMNZ-bfYrA@mail.gmail.com>
In-Reply-To: <xmqqa8pqrlz0.fsf@gitster.mtv.corp.google.com>

On Fri, Dec 4, 2015 at 9:35 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> ... Now I conclude
>> that setup-messed-by-alias is always evil. So the env restoration is
>> done for _all_ commands  whenever aliases are involved.
>
> So a side effect of this is whenever an alias is involved, all
> commands are re-spawned, not just the external ones but builtins as
> well.

I missed that while re-reading c056261, but yes that's true. So
Windows folks will be grumpy anyway. Maybe we can avoid that in
certain (safe) cases, when we know the second setup_git_... will be
executed by the builtin command and won't have any side effects, which
is probably the common case. But let's see how it goes.
-- 
Duy