From: Duy Nguyen Date: Sat, 18 Aug 2018 16:10:44 GMT Subject: Re: [PATCH 7/7] submodule--helper: introduce new update-module-mode helper Message-ID: In-Reply-To: <20180813224235.154580-8-sbeller@google.com> On Tue, Aug 14, 2018 at 12:45 AM Stefan Beller wrote: > +static int module_update_module_mode(int argc, const char **argv, const char *prefix) > +{ > + const char *path, *update = NULL; > + int just_cloned; > + struct submodule_update_strategy update_strategy = { .type = SM_UPDATE_CHECKOUT }; > + > + if (argc < 3 || argc > 4) > + die("submodule--helper update-module-clone expects []"); Maybe _() ? -- Duy