From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Wed, 10 Oct 2012 05:14:50 GMT
Subject: Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case
Message-ID: <CACsJy8BOcH8cXje5osL4oNP1YkJ8HadUOYBek3uhEbySBey9Kw@mail.gmail.com>
In-Reply-To: <7vtxu3e5jl.fsf@alter.siamese.dyndns.org>

On Wed, Oct 10, 2012 at 3:47 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> diff --git a/wildmatch.c b/wildmatch.c
>> index 7b64a6b..2382873 100644
>> --- a/wildmatch.c
>> +++ b/wildmatch.c
>> @@ -11,8 +11,8 @@
>>
>>  #include <stddef.h>
>>  #include <ctype.h>
>> -#include <string.h>
>>
>> +#include "cache.h"
>>  #include "wildmatch.h"
>
> This is wrong; the includes from the system headers should have
> been removed in the previous step where the series "integrated"
> wildmatch to git, after which point the first include any C source
> that is not at the platform-compatibility layer should be cache.h
> or git-compat-util.h.

Git's ctype does not seem to be complete for wildmatch's use so
ctype.h is required. But that can be easily fixed later on.
-- 
Duy