From: Duy Nguyen <pclouds@gmail.com>
Date: Sat, 08 Mar 2014 08:57:49 GMT
Subject: Re: [PATCH v5 01/28] path.c: make get_pathname() return strbuf instead of static buffer
Message-ID: <CACsJy8BMK-CkzQjx5cRA6EK4rHdvng9QtNuh5jexd2UKpM_CyA@mail.gmail.com>
In-Reply-To: <531AB47B.7070506@web.de>

On Sat, Mar 8, 2014 at 1:11 PM, Torsten Bögershausen <tboegi@web.de> wrote:
> On 2014-03-08 03.47, Nguyễn Thái Ngọc Duy wrote:
>> We've been avoiding PATH_MAX whenever possible. This patch makes
>> get_pathname() return a strbuf and updates the callers to take
>> advantage of this. The code is simplified as we no longer need to
>> worry about buffer overflow.
>>
>> vsnpath() behavior is changed slightly: previously it always clears
> Minor question:
> Is the function name vsnpath() appropriate any more ?
> How about renaming the function into strbuf_vaddpath() ?

It is renamed in 04/28 to do_git_path().
-- 
Duy