From: Duy Nguyen <pclouds@gmail.com>
Date: Fri, 07 Apr 2017 11:38:04 GMT
Subject: Re: [PATCH v2 11/20] refs: record the ref_store in ref_cache, not ref_dir
Message-ID: <CACsJy8BM1nHhbKo9ioAP2OC2UU-RMWhmJ5OsYZwWYqek++DA0Q@mail.gmail.com>
In-Reply-To: <7e63849fdb197cd66b229a28408845908fa844a7.1490966385.git.mhagger@alum.mit.edu>

On Fri, Mar 31, 2017 at 9:11 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> Instead of keeping a pointer to the ref_store in every ref_dir entry,
> store it once in `struct ref_cache`, and change `struct ref_dir` to
> include a pointer to its containing `ref_cache` instead. This makes it
> easier to add to the information that is accessible from a `ref_dir`
> without increasing the size of every `ref_dir` instance.
...
> @@ -526,7 +526,7 @@ static struct ref_dir *get_loose_refs(struct files_ref_store *refs)
>                  * lazily):
>                  */
>                 add_entry_to_dir(get_ref_dir(refs->loose->root),
> -                                create_dir_entry(refs, "refs/", 5, 1));
> +                                create_dir_entry(refs->loose, "refs/", 5, 1));

The commit message mentions nothing about this change. Is it intended?
-- 
Duy