From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Wed, 10 Oct 2012 12:03:33 GMT
Subject: Re: [PATCH 3/3] grep: stop looking at random places for .gitattributes
Message-ID: <CACsJy8BG0HJNePG-j27SrfEenEkZ5a5nCdMEuDGn=qXxq=VzhA@mail.gmail.com>
In-Reply-To: <5075615B.8020702@viscovery.net>

On Wed, Oct 10, 2012 at 6:51 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> Thanks for working on this issue!
>
> Am 10/10/2012 13:34, schrieb Nguyễn Thái Ngọc Duy:
>> +     linkgit:gitattributes[5]). Note that .gitattributes are only
>> +     support for searching files in working directory.
>
> Does this mean it does not work for 'git grep --cached'? That would be a
> real loss.

I missed this case. I don't think it works correctly before as it
reads worktree's .gitattributes instead of the index version. But at
least we support reading .gitattributes from index. Patches coming
soon.
-- 
Duy