From: Duy Nguyen <pclouds@gmail.com>
Date: Wed, 04 Jun 2014 13:47:58 GMT
Subject: Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");
Message-ID: <CACsJy8BDk4gdRzjp_XpQXXMW1sEnS4DoedanFLONODuJXdeeRA@mail.gmail.com>
In-Reply-To: <20140604114730.GB22250@camelia.ucw.cz>

On Wed, Jun 4, 2014 at 6:47 PM, Stepan Kasal <kasal@ucw.cz> wrote:
> @@ -133,7 +133,7 @@ char *git_path(const char *fmt, ...)
>  void home_config_paths(char **global, char **xdg, char *file)
>  {
>         char *xdg_home = getenv("XDG_CONFIG_HOME");
> -       char *home = getenv("HOME");
> +       const char *home = get_home_directory();
>         char *to_free = NULL;
>
>         if (!home) {

Just checking. Instead of replace the call sites, can we check and
setenv("HOME") if it's missing instead? MinGW port already replaces
main(). Extra initialization should not be a problem. I feel
"getenv("HOME")" a tiny bit more familiar than get_home_directory(),
but that's really weak argument as the number of call sites has not
increased in 4 years.
-- 
Duy

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.