From: Duy Nguyen <pclouds@gmail.com>
Date: Fri, 01 Jul 2016 18:46:30 GMT
Subject: Re: [PATCH v2 00/12] nd/icase updates
Message-ID: <CACsJy8BBQqxzT8jdaysyeDv3ja=DTD6R-whA3Lhr3pEs-2x8dA@mail.gmail.com>
In-Reply-To: <xmqq4m89z0gl.fsf@gitster.mtv.corp.google.com>

On Fri, Jul 1, 2016 at 8:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> Makes sense. But then if opt->ignore_case is false and regflags
>> happens to have REG_ICASE set, should we clear it as well?
>
> I think .ignore_case is set iff '-i' is given, and .regflags has
> REG_ICASE only if '-i' is given and the user said she does not want
> literal string match (i.e. no '-F').
>
> So... can .regflags have REG_ICASE when .ignore_case is false?

Yeah reg_icase is more like a subset of ignore_case. Ignore what I wrote.
-- 
Duy