From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Thu, 06 Sep 2012 12:13:37 GMT
Subject: Re: [PATCH 5/9] Refactor excluded and path_excluded
Message-ID: <CACsJy8Aq7Sodm1_k2kAmfajHG4wP76xHCshDGPfiLYfzuNwWaA@mail.gmail.com>
In-Reply-To: <7v627r7s5c.fsf@alter.siamese.dyndns.org>

On Thu, Sep 6, 2012 at 10:21 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> We could introduce exclude_path() and kill path_excluded() then. There
>> are just about 5-6 call sites to replace.
>
> The name path_excluded(... path ...) sounds like it is asking a
> yes/no question "is this path excluded?", which actually is what is
> going on.
>
> The name exclude_path(... path ...) sounds as if you are requesting
> somebody to exclude the path.  Does that meaning match the semantics
> of the function?

I'm not great at naming. And path_excluded() cannot be reused to avoid
problems with other ongoing series if any. So path_is_excluded()?
-- 
Duy