From: Duy Nguyen <pclouds@gmail.com>
Date: Sun, 09 Nov 2014 08:34:17 GMT
Subject: Re: [PATCH v2 22/22] untracked cache: guard and disable on system changes
Message-ID: <CACsJy8Am8+XcKzd5vqODLkCVAerMW_619c2XQsL35R6-k0F7-g@mail.gmail.com>
In-Reply-To: <CAPig+cRNpgBNr0cT6P-tsMc3McyC4aC7czcQYz0P+9_uSpkZSw@mail.gmail.com>

On Sun, Nov 9, 2014 at 10:39 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> --- a/test-dump-untracked-cache.c
>> +++ b/test-dump-untracked-cache.c
>> @@ -44,6 +44,7 @@ int main(int ac, char **av)
>>  {
>>         struct untracked_cache *uc;
>>         struct strbuf base = STRBUF_INIT;
>> +       setup_git_directory();
>
> What is this change about? Is it related to the rest of this patch?

Yes. This patch makes use of get_git_work_tree() from read_cache()
below. Without setup_git_... worktree is not set up,
read_untracked_extension() thinks the repo is moved and returns no
cache. I'll make a note about this.

>
>>         if (read_cache() < 0)
>>                 die("unable to read index file");
>>         uc = the_index.untracked;




-- 
Duy