From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Wed, 25 Apr 2012 10:46:45 GMT
Subject: Re: [PATCH 03/10] i18n: mark relative dates for translation
Message-ID: <CACsJy8Ae_9wEoNmP81Gqu5kOMGrEKSN9PMvoRXbKh8TnwGVt0A@mail.gmail.com>
In-Reply-To: <xmqqd36wgam5.fsf@junio.mtv.corp.google.com>

2012/4/25 Junio C Hamano <gitster@pobox.com>:
>>       /* Give years and months for 5 years or so */
>>       if (diff < 1825) {
>> ...
>>       }
>>       /* Otherwise, just years. Centuries is probably overkill. */
>> -     snprintf(timebuf, timebuf_size, "%lu years ago", (diff + 183) / 365);
>> -     return timebuf;
>> +     strbuf_addf(timebuf,
>> +              Q_("%lu year ago", "%lu years ago", (diff + 183) / 365),
>> +              (diff + 183) / 365);
>>  }
>
> This is just a tangent, but could we possibly come here and say "1 year
> ago"?

Nice catch. Singular form here is unnecessary. If you plan to revert
that, please put a comment so nobody will attempt to convert it to
Q_() again next time while searching for possible candidates.
-- 
Duy