From: Duy Nguyen Date: Thu, 16 Jun 2016 12:11:29 GMT Subject: Re: [PATCH] grep: fix grepping for "intent to add" files Message-ID: In-Reply-To: <20160616114452.GA21930@hashpling.org> On Thu, Jun 16, 2016 at 6:44 PM, Charles Bailey wrote: > On Thu, Jun 16, 2016 at 05:57:18PM +0700, Duy Nguyen wrote: >> >> "git grep --cached" searches file content that will be committed by >> "git commit" (no -a). An i-t-a entry will not be committed (you would >> need "git add" first, or do "git commit -a"). So if I say "search >> among the to-be-committed file content, list files that do not match >> abc" (git grep -l -v --cached abc), the i-t-a entry will show up >> because its fake content is empty (i.e. not contain "abc"), even >> though it's not in the "to-be-committed" list. So yeah, correctness >> issue. > > OK, I think there is an issue there but it's not with "-l -v --cached" > but rather with "-L --cached". If my understanding is correct, "-l -v" > means "has a line that doesn't match" whereas "-L" means "has no line > that matches". > > Does this sound correct? I'll try adding a new test. Yeah "-L --cached" should work the same, I think. -- Duy