From: Duy Nguyen Date: Tue, 23 Oct 2018 15:44:41 GMT Subject: Re: [PATCH] khash: silence -Wunused-function Message-ID: In-Reply-To: <20181023113416.90958-1-carenas@gmail.com> On Tue, Oct 23, 2018 at 1:42 PM Carlo Marcelo Arenas Belón wrote: > > after 36da893114 ("config.mak.dev: enable -Wunused-function", 2018-10-18) > macro generated code should use a similar solution than commit-slab to > silence the compiler. > > Signed-off-by: Carlo Marcelo Arenas Belón > --- > khash.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/khash.h b/khash.h > index d10caa0c35..39c2833877 100644 > --- a/khash.h > +++ b/khash.h > @@ -234,7 +234,7 @@ static const double __ac_HASH_UPPER = 0.77; > __KHASH_IMPL(name, SCOPE, khkey_t, khval_t, kh_is_map, __hash_func, __hash_equal) > > #define KHASH_INIT(name, khkey_t, khval_t, kh_is_map, __hash_func, __hash_equal) \ > - KHASH_INIT2(name, static inline, khkey_t, khval_t, kh_is_map, __hash_func, __hash_equal) > + KHASH_INIT2(name, __attribute__((__unused__)) static inline, khkey_t, khval_t, kh_is_map, __hash_func, __hash_equal) Maybe move MAYBE_UNUSED from commit-slab-impl.h to git-compat-util.h and use it here so we have an easier time if we have to use a different way to mark unused functions on some exotic platform. > > /* Other convenient macros... */ > > -- > 2.19.1 > -- Duy