From: Duy Nguyen Date: Sat, 05 Jul 2014 10:48:49 GMT Subject: Re: [PATCH 2/2] dir: remove PATH_MAX limitation Message-ID: In-Reply-To: <53B72DD5.6020603@gmail.com> On Sat, Jul 5, 2014 at 5:42 AM, Karsten Blees wrote: > 'git status' segfaults if a directory is longer than PATH_MAX, because > processing .gitignore files in prep_exclude() writes past the end of a > PATH_MAX-bounded buffer. > > Remove the limitation by using strbuf instead. > > Note: this fix just 'abuses' strbuf as string allocator, len is always 0. > prep_exclude() can probably be simplified using more strbuf APIs. FYI I had a similar patch [1] that attempted to lazily strbuf_init() instead so that strbuf_ API could be used. [1] http://article.gmane.org/gmane.comp.version-control.git/248310 -- Duy -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.