From: Nguyen Thai Ngoc Duy Date: Tue, 16 Oct 2012 11:15:01 GMT Subject: Re: [PATCH UI experiment] diffstat: annotate/highlight new or removed files Message-ID: In-Reply-To: <7v626bwir8.fsf@alter.siamese.dyndns.org> On Tue, Oct 16, 2012 at 4:03 AM, Junio C Hamano wrote: >> Coloring is to me an improvement over --summary. Probably the main >> point. Without it, perhaps it's not worth putting extra text to >> diffstat. > > It is kind of surprising that you did not choose to paint new in > green and gone in red, and rather paint everything in yellow. The colors of line addition and deletion? Nice. I just wanted to make sure these stand out, or at least not easily mistaken as part of path names. > I personally think the above in monochrome is fairly easy to read; > with coloring, it might become too distracting, though. Hmm.. maybe. I'm probably too excited to see the distraction just yet. I will try it out for longer time, see if I change my mind. > Just a nit, "new mode" is too similar to "new". Everything is "new" > in the sense that they have "new contents"; it may be better phrased > without saying "new" but giving a stress on "changed". I think "new mode" should be replaced by the actual mode change (e.g. "+x", "-x", or "mode +x", "mode -x"). Not too long and quite clear what it does. -- Duy