From: Duy Nguyen <pclouds@gmail.com>
Date: Mon, 03 Nov 2014 12:16:46 GMT
Subject: Re: [PATCH 18/19] update-index: test the system before enabling untracked cache
Message-ID: <CACsJy8ASZX6rVMgUrScFh-RWWhuhQ+P_H1bwb9OvwmC+DRp9zg@mail.gmail.com>
In-Reply-To: <544FD474.3050805@web.de>

On Wed, Oct 29, 2014 at 12:37 AM, Torsten Bögershausen <tboegi@web.de> wrote:
> On 2014-10-27 13.10, Nguyễn Thái Ngọc Duy wrote:
> []
>
>> +static void xmkdir(const char *path)
>> +{
>> +     if (mkdir(path, 0700))
>> +             die_errno(_("failed to create directory %s"), path);
>> +}
>
> Does it makes sense to ignore EINTR and do a "retry" ?
> Another question is if the function could be called mkdir_or_die() instead?
>
> I realized that there are 2 families of xfunc() in wrapper.c, some die, some retry.

This is only used interactively, I think it's ok to ignore EINTR as
long as we report clearly the case (and hope the user to re-enter the
command)
-- 
Duy