From: Duy Nguyen <pclouds@gmail.com>
Date: Wed, 22 Jan 2014 23:56:47 GMT
Subject: Re: problematic git log submodule-dir/
Message-ID: <CACsJy8AQxwxq3x5eg0-NssDB2PQz7uaLw9oK0Otg+jW7HtG+2g@mail.gmail.com>
In-Reply-To: <52E02B8C.6040309@web.de>

On Thu, Jan 23, 2014 at 3:35 AM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> Am 20.01.2014 19:25, schrieb Paweł Sikora:
>> i've noticed that 'git log submodule-dir' and 'git log submodule-dir/'
>> return different results (module's head changes vs. nothing). is it a bug?
>> looks like a trailing slash is a problem for git-log.
>
> I think this is a bug, and for example "git diff" has similar problems.
> This is especially nasty as shell auto-completion adds the '/' at the
> end.
>
> Duy, without having looked into the code myself yet: is this something
> that might be easily fixed by using PATHSPEC_STRIP_SUBMODULE_SLASH*?

I think so. But I dislike those preprocessing because it looks
inefficient and the same change may be needed for other diff commands
as well. Maybe we can handle this at diff or log-tree.c level. Will
look further into it tonight.
-- 
Duy