From: Duy Nguyen Date: Sun, 29 Jul 2018 15:46:17 GMT Subject: Re: [PATCH] pack-objects: document about thread synchronization Message-ID: In-Reply-To: <20180729153605.27298-1-pclouds@gmail.com> tOn Sun, Jul 29, 2018 at 5:36 PM Nguyễn Thái Ngọc Duy wrote: > > These extra comments should be make it easier to understand how to use > locks in pack-objects delta search code. For reference, see Side note. I wonder if we could take progress_lock() less often in find_deltas() to reduce contention. Right now we take the lock every time we check out one object_entry but we could pull like 16 items out of the list per lock. I don't know how much actual contention on this lock though so maybe not worth doing. -- Duy