From: Nguyen Thai Ngoc Duy Date: Thu, 12 Jan 2012 01:27:33 GMT Subject: Re: [PATCH v3 06/10] clone: delay cloning until after remote HEAD checking Message-ID: In-Reply-To: <7v8vle6ng3.fsf@alter.siamese.dyndns.org> 2012/1/12 Junio C Hamano : >> @@ -938,6 +940,7 @@ struct transport *transport_get(struct remote *remote, const char *url) >>               char *handler = xmalloc(len + 1); >>               handler[len] = 0; >>               strncpy(handler, url, len); >> +             remote->foreign_vcs = helper; >>               transport_helper_init(ret, handler); >>       } > > This I am not sure. What value does "helper" variable have at this point > in the flow? Wouldn't it be a NULL? Or did you mean "handler"? Ah yes "handler", my bad. -- Duy