From: Duy Nguyen <pclouds@gmail.com>
Date: Sat, 25 Jun 2016 14:15:32 GMT
Subject: Re: [PATCH v12 04/20] index-helper: new daemon for caching index and related stuff
Message-ID: <CACsJy8A6C8i_XbXRRBBmT5iqq=mSovVGhFqe0d9WroyMVKf5RA@mail.gmail.com>
In-Reply-To: <CAP8UFD0RAgUmKr4tG7xHcz75vpXAeuWi9t1+9mvbGOVzOcHcFA@mail.gmail.com>

On Fri, Jun 17, 2016 at 6:43 PM, Christian Couder
<christian.couder@gmail.com> wrote:
> On Thu, May 19, 2016 at 11:45 PM, David Turner <dturner@twopensource.com> wrote:
>> From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>>
>> +static void loop(int fd, int idle_in_seconds)
>> +{
>> +       assert(idle_in_seconds < INT_MAX / 1000);
>
> This assert may not be very nice to users setting the value using --exit-after.

Yeah. We could catch this after parsing --exit-after (and before
forking to background, losing stderr) for invalid values and forget
about this assert.
-- 
Duy