From: Nguyen Thai Ngoc Duy Date: Fri, 28 Dec 2012 06:56:56 GMT Subject: Re: [PATCH 8/8] wildmatch: advance faster in + patterns Message-ID: In-Reply-To: <7vpq1uk82q.fsf@alter.siamese.dyndns.org> On Fri, Dec 28, 2012 at 1:24 PM, Junio C Hamano wrote: >> + while ((t_ch = *text) != '\0' && >> + (!(flags & WM_PATHNAME) || t_ch != '/')) { > > Why do we look at (flags & WM_PATHMAME) and not "special" here? Because I was careless. Thanks for spotting it. I'll fix it and add some more tests about ** with WM_PATHNAME. -- Duy