From: Duy Nguyen <pclouds@gmail.com>
Date: Mon, 30 Jun 2014 13:59:53 GMT
Subject: Re: [PATCH v2 2/2] sha1_file: use strncmp for string comparison
Message-ID: <CACsJy8A5Dq6MP8kH7R3POSjXoJjYvWF695fKj1YgTdscF5xYxA@mail.gmail.com>
In-Reply-To: <20140630134317.GB14799@sigill.intra.peff.net>

On Mon, Jun 30, 2014 at 8:43 PM, Jeff King <peff@peff.net> wrote:
>> diff --git a/sha1_file.c b/sha1_file.c
>> index 394fa45..8adab14 100644
>> --- a/sha1_file.c
>> +++ b/sha1_file.c
>> @@ -1207,7 +1207,8 @@ static void prepare_packed_git_one(char *objdir, int local)
>>               if (has_extension(de->d_name, ".idx")) {
>>                       /* Don't reopen a pack we already have. */
>
> If we don't follow my suggestion above, we still have this
> has_extension. This is a reimplementation of ends_with, isn't it? We can
> probably drop it and just use ends_with.

This calls for another patch if we just want to kill has_extension()
in favor of ends_with(). There are 12 call sites of it.
-- 
Duy