From: Duy Nguyen Date: Tue, 22 Dec 2015 11:53:16 GMT Subject: Re: [PATCH v2 0/3] nd/clear-gitenv-upon-use-of-alias Message-ID: In-Reply-To: On Tue, Dec 22, 2015 at 5:57 PM, Duy Nguyen wrote: > On Tue, Dec 22, 2015 at 4:18 AM, Junio C Hamano wrote: >> Thanks. I wiggled these three on top of the "Revert the earlier >> one"; while I think the result is correct, I'd appreciate if you can >> double check the result when I push the topic out later today. > > Looks good. "prove" passed too by the way. Another by the way, this "forcing aliases as external commands" now shows something like "error: git-log died of signal 13" when the pager exits early, for an alias like "l1 = log --oneline". It's probably not a regression because other external git commands with pager should show the same message. But I haven't checked thoroughly yet. -- Duy