From: Nguyen Thai Ngoc Duy Date: Fri, 16 Mar 2012 02:24:34 GMT Subject: Re: [PATCH] {fetch,receive}-pack: skip sha-1 integrity test on objects from new pack Message-ID: In-Reply-To: <7vy5r1inax.fsf@alter.siamese.dyndns.org> 2012/3/16 Junio C Hamano : > Nguyễn Thái Ngọc Duy   writes: > >> When we fetch or push, usually "git rev-list --verify-objects --not >> --all --stdin" is used to make sure that all objects between existing >> refs and new refs are good. This means no gaps in between, all objects >> are well-formed, object content agrees with its sha-1 signature. >> >> For the last one, --verify-objects calls check_sha1_signature() via >> parse_object(). check_sha1_signature() is an expensive operation, > > After thinking about this a bit more, I am beginning to think that the > validation of object contents is unnecessary in _all_ cases that involve > "git fetch".  Unpack-objects and index-pack already validate individual > objects, and the only thing we would want to catch are objects that we > already happened to have had in our repository but were unreferenced from > our refs. What about remote helpers? Should we declare it's remote helper responsibility to validate all incoming objects? -- Duy