From: Heba Waly <heba.waly@gmail.com>
Date: Mon, 17 Feb 2020 10:03:18 GMT
Subject: Re: [PATCH v2 1/2] advice: refactor advise API
Message-ID: <CACg5j25nNAWqXP6jXUBxkwC=hEd7_9Nw3hfQNpPKgEW1JabxgQ@mail.gmail.com>
In-Reply-To: <xmqq8sl1nb98.fsf@gitster-ct.c.googlers.com>

On Mon, Feb 17, 2020 at 4:28 PM Junio C Hamano <gitster@pobox.com> wrote:
>
>And I see that now you are going all the way to discard the
>string-based keys to enumeration, I think this deserves to be called
>"revamp advise API".

Fair enough.

> There seem to be a handful of lines with trailing whitespaces.  I
> think I've fixed them all on the receiving end, but please proofread
> before you come up with the next round.
>

Sorry about that, I fixed this setting in my IDE a while ago but looks
like it has a bug.
Will keep an eye on it in the future, thanks

> Thanks.

Heba