From: Robert Coup Date: Mon, 28 Feb 2022 11:51:42 GMT Subject: Re: [PATCH v2 6/8] maintenance: add ability to pass config options Message-ID: In-Reply-To: <220225.86tucn8ch4.gmgdl@evledraar.gmail.com> Hi Ævar, On Fri, 25 Feb 2022 at 10:30, Ævar Arnfjörð Bjarmason wrote: > > Shouldn't this bei using git grep the git_config_push.*parameter() > functions instead of adding a new custom method to do this. > > Perhaps there's some subtle distinction between the two that's important > here, or perhaps you just didn't know about that API... I didn't know of it — it could probably use a docstring too ;-) A few other sub-commands seemed to use the `-c key=value` approach so it didn't seem like GIT_CONFIG_PARAMETERS was universal. Easy enough to swap to, thanks. Assuming we want it, but I'm about to reply to Junio's email. Rob :)