From: Robert Coup <robert@coup.net.nz>
Date: Mon, 28 Feb 2022 12:22:35 GMT
Subject: Re: [PATCH v2 1/8] fetch-negotiator: add specific noop initializor
Message-ID: <CACf-nVcLXcD6G_b_pYWj+7KJBu4iV6FqHWB8U6F4j6Rr72zXVg@mail.gmail.com>
In-Reply-To: <xmqqbkyvh3i3.fsf@gitster.g>

Hi,

On Fri, 25 Feb 2022 at 06:19, Junio C Hamano <gitster@pobox.com> wrote:
>
> > Add a specific initializor for the noop fetch negotiator. This is
>
> "initializer"?

Thanks. A poor translation effort to American English ;-)

> > +
> > +void fetch_negotiator_init_noop(struct fetch_negotiator *negotiator)
> > +{
> > +     noop_negotiator_init(negotiator);
> > +}
>
> Puzzling.  What makes this better than allowing noop-negotiator-init
> to be called directly?

Is simply for naming/API consistency with the regular method. Happy to
call noop_negotiator_init() if you prefer?

Rob :)