From: Paul Tan <pyokagan@gmail.com>
Date: Wed, 18 Mar 2015 06:39:39 GMT
Subject: Re: [PATCH v3 1/4] git-credential-store: support multiple credential files
Message-ID: <CACRoPnRpSV9q1A24=8jP1bRCf5sTZRY7owWqMtWCGq-R1b5Rjg@mail.gmail.com>
In-Reply-To: <xmqqy4myt4dt.fsf@gitster.dls.corp.google.com>

Hi all, thanks for providing your feedback.

On Sun, Mar 15, 2015 at 6:14 AM, Junio C Hamano <gitster@pobox.com> wrote:
> I am not sure if this is not a premature over-engineering---I am not
> convinced that such a future need will be fulfilled by passing just
> a single default_fn this version already passes, or it needs even
> more parameters that this version does not pass yet, and the
> interface to the function needs to be updated at that point when you
> need it _anyways_. One thing that we all agree is that we don't need
> the extra parameter within the context of what the current code does.

After considering everyone's responses, I've decided to remove the
argument in the v4 patch. As Junio says, when there is a policy change
the code can be modified anyway.

Regards,
Paul