From: Paul Tan <pyokagan@gmail.com>
Date: Wed, 01 Jul 2015 06:43:16 GMT
Subject: Re: [PATCH v4 43/44] builtin-am: check for valid committer ident
Message-ID: <CACRoPnRH_Wr=pVF-3yp70hhB4AvcfCF91yrh+eeKzyq9Oxh38Q@mail.gmail.com>
In-Reply-To: <CAGZ79kaUYS1kiiFTwTTA=Wh924JcHMLOU61mSuMZxiqZFO7PPw@mail.gmail.com>

On Tue, Jun 30, 2015 at 4:02 AM, Stefan Beller <sbeller@google.com> wrote:
> On Sun, Jun 28, 2015 at 7:06 AM, Paul Tan <pyokagan@gmail.com> wrote:
>> When commit_tree() is called, if the user does not have an explicit
>> committer ident configured, it will attempt to construct a default
>> committer ident based on the user's and system's info (e.g. gecos field,
>> hostname etc.) However, if a default committer ident is unable to be
>> constructed, commit_tree() will die(). However, at this point of git-am,
>
> s/. However,/, but/ ?

Yeah, thanks.

Regards,
Paul