From: Paul Tan <pyokagan@gmail.com>
Date: Mon, 15 Jun 2015 09:49:57 GMT
Subject: Re: [PATCH/WIP v2 03/19] am: implement skeletal builtin am
Message-ID: <CACRoPnR28kNvxk6sdYaNkPYx7wi=j4wCbaXYrx62AGhjpQiPVA@mail.gmail.com>
In-Reply-To: <xmqqzj42kkol.fsf@gitster.dls.corp.google.com>

On Mon, Jun 15, 2015 at 6:08 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Paul Tan <pyokagan@gmail.com> writes:
>> diff --git a/git.c b/git.c
>> index 44374b1..42328ed 100644
>> --- a/git.c
>> +++ b/git.c
>> @@ -370,6 +370,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
>>
>>  static struct cmd_struct commands[] = {
>>       { "add", cmd_add, RUN_SETUP | NEED_WORK_TREE },
>> +     { "am", cmd_am, RUN_SETUP | NEED_WORK_TREE },
>
> Would this, especially having RUN_SETUP, keep the same behaviour
> when the command is run from a subdirectory of a working tree?
> e.g.
>
>         save messages to ./inbox
>         $ cd sub/dir
>         $ git am ../../inbox
>

Yes, in 05/19, where the splitting of patches is implemented, we
prefix the mbox paths with the path to the working tree.

There are also tests in t4150 to catch this, introduced in bb034f8
(am: read from the right mailbox when started from a subdirectory,
2008-03-04).

Thanks,
Paul