From: Paul Tan <pyokagan@gmail.com>
Date: Wed, 03 Jun 2015 07:57:34 GMT
Subject: Re: [PATCH/WIP 6/8] am: extract patch, message and authorship with git-mailinfo
Message-ID: <CACRoPnQVfUke3eGbTE-sQbV8drH7tDcE+YOpSP0xGtgk9z_FTA@mail.gmail.com>
In-Reply-To: <xmqqh9qxk6tb.fsf@gitster.dls.corp.google.com>

On Thu, May 28, 2015 at 6:13 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Paul Tan <pyokagan@gmail.com> writes:
>
>> +static const char *msgnum(const struct am_state *state)
>> +{
>> +     static struct strbuf fmt = STRBUF_INIT;
>> +     static struct strbuf sb = STRBUF_INIT;
>> +
>> +     strbuf_reset(&fmt);
>> +     strbuf_addf(&fmt, "%%0%dd", state->prec);
>> +
>> +     strbuf_reset(&sb);
>> +     strbuf_addf(&sb, fmt.buf, state->cur);
>
> Hmph, wouldn't ("%*d", state->prec, state->cur) work or am I missing
> something?

Yeah, I think it would. I justs didn't know about the existence of '*'.

Thanks,
Paul