From: Maciej Ciemborowicz <maciej.ciemborowicz@gmail.com>
Date: Thu, 24 Sep 2026 20:13:33 GMT
Subject: Re: [PATCH v5 1/3] refs: allow callers to supply old OIDs for batch deletion
Message-ID: <CACQ=SRGA5j9ChJ0uM4=5iCwEDgWQEdhhrD8OF9=RJ7XBxqb0dQ@mail.gmail.com>
In-Reply-To: <xmqq4ife4mzc.fsf@gitster.g>

On Thu, Sep 24, 2026 at 6:45 PM Junio C Hamano <gitster@pobox.com> wrote:

> "callers cannot preserve", meaning "after deletion the values cannot
> be read anymore"?  Of course, but then callers can read them
> beforehand and use the stored value when calling hooks later.

I meant that refs_delete_refs() has no parameter for
the values its callers have already resolved, so those values are not
carried into the transaction and are therefore not available to the hook.

Patrick's later suggestion to resolve missing old values in the common hook
layer seems to avoid this API question altogether.

Thanks,
- Maciej Ciemborowicz