From: Ævar Arnfjörð Bjarmason Date: Tue, 29 May 2012 22:51:08 GMT Subject: Re: "docs: stop using asciidoc no-inline-literal" breaks asciidoc 8.2.5 Message-ID: In-Reply-To: On Wed, May 30, 2012 at 12:42 AM, Ævar Arnfjörð Bjarmason wrote: > On Tue, May 29, 2012 at 11:56 PM, Jeff King wrote: > >> I'm very sympathetic to having platform support dropped. It's annoying >> for the user. But given that it's a 3rd-party install anyway (and you >> can install a newer 3rd-party RPM), and that you can additionally use >> "make quick-install-man" to avoid needing asciidoc entirely, and given >> the sheer number of bugs this patch fixes (and prevents), to me the >> balance still argues for keeping the patch. > > To be clear I like the patch, I was just suggesting that we might want > to hold it off for a bit. > > Anyway, I've tested dropping asciidoc.py from the source distribution > into compat/asciidoc.py and doing "make doc > ASCIIDOC=../compat/asciidoc.py", it seems to work. > > I wonder if the easiest solution is to change the default asciidoc > invocation from "asciidoc" to a small Documentation/asciidoc.sh script > that we supply, it would check if there's an asciidoc present on the > system, whether it's sufficiently new, and if not fall back on a copy > we have in compat/. Something like this silly patch, which seems to work, but needs cleanup: https://github.com/avar/git/compare/git:master...avar/asciidoc-fallback