From: Ævar Arnfjörð Bjarmason Date: Fri, 27 Jan 2012 09:33:32 GMT Subject: Re: [PATCH 1/4] config: add include directive Message-ID: In-Reply-To: <20120127003241.GA15165@sigill.intra.peff.net> On Fri, Jan 27, 2012 at 01:32, Jeff King wrote: > On Fri, Jan 27, 2012 at 01:02:52AM +0100, Ævar Arnfjörð Bjarmason wrote: > >> On Thu, Jan 26, 2012 at 08:37, Jeff King wrote: >> > This patch introduces an include directive for config files. >> > It looks like: >> > >> >  [include] >> >    path = /path/to/file >> >> Very nice, I'd been meaning to resurrect my gitconfig.d series, and >> this series implements a lot of the structural changes needed for that >> sort of thing. > > Yeah, that seems like a reasonable thing to do. It could make life > easier for package managers (I think the only reason it has not come up > much is that there simply isn't a lot of third-party git config). > >> What do you think of an option (e.g. include.gitconfig_d = true) that >> would cause git to look in: >> >>     /etc/gitconfig.d/* >>     ~/.gitconfig.d/* >>     .git/config.d/* > > Hmm. Is that really worth having an option? I.e., why not just always > check those directories? You're right, always just including those directories is a much better option, an extra stat() doesn't cost us much. Thanks again for working on this.