From: Ævar Arnfjörð Bjarmason Date: Fri, 09 Mar 2012 11:24:36 GMT Subject: Re: [PATCH 1/5] i18n: keep the last \n even when text is poisoned Message-ID: In-Reply-To: <20120308220131.GA10122@burratino> 2012/3/8 Jonathan Nieder : > The latter wins out for me, so I would prefer not to have this patch > so the test suite can detect important newlines that should be not be > part of the translatable string. FWIW that's why I kept it this way. I can't recall the specific cases but I smoked out some issues with the poison feature that I wouldn't have smoked out if it had a \n at the end. Arguably we should make it even less user friendly and have it randomly output 10-50 bytes of binary garbage to catch more errors.