From: Michael Montalbo <mmontalbo@gmail.com>
Date: Mon, 01 Jun 2026 04:28:43 GMT
Subject: Re: [PATCH v3 0/6] [RFC] diff: add diff.<driver>.process for external hunk providers
Message-ID: <CAC2QwmJu=Ud_qQMB7T2zmjiGpxk0=s0T_ZEt4Ei+ssHF2DHZ6w@mail.gmail.com>
In-Reply-To: <xmqq5x43dfk4.fsf@gitster.g>

On Sun, May 31, 2026 at 3:44 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> "Michael Montalbo via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > Language-aware diff tools (e.g., Difftastic) and format-specific analyzers
> > can produce better line matching than Git's builtin diff algorithm, but
> > diff.<driver>.command replaces Git's output entirely, losing downstream
> > features like word diff, function context, color, and blame.
>
> This seems to break CI on Windows; take a look at
>
>   https://github.com/git/git/actions/runs/26709491830/job/78717295153
>
> for an example.
>
> Thanks.

Thanks for the heads up. Interestingly, I think Windows exposed a latent issue
with sub-process startup dying instead of erroring out when there is a space in
the path.

I've submitted https://lore.kernel.org/git/pull.2133.git.1780287309846.gitgitgadget@gmail.com/T/#u
which I believe addresses the issue, however it seems like there are
some potentially
unrelated CI failures going on right now which is making verification
a bit harder.