From: Haitao Li <lihaitao@gmail.com>
Date: Wed, 07 Sep 2011 03:00:59 GMT
Subject: Re: [PATCH] date.c: Parse timezone with colon as separator
Message-ID: <CABk5KLh230zLfkdaEgv7SDC6ivKqwvaGJQFVEKkKtGjMyEmLog@mail.gmail.com>
In-Reply-To: <20110906202440.GD14554@sigill.intra.peff.net>

> That seems like a sensible list to support, given that it is part of
> iso8601 (though I was a little surprised after reading your subject
> line, which would probably be better as "support iso8601 timezone
> formats").

I agree this is a better one! ;)

> We should probably have new tests, too. I was going to suggest squashing
> in the ones below, but your patch doesn't seem to work with the first
> one:
>
> diff --git a/t/t0006-date.sh b/t/t0006-date.sh
> index f87abb5..9b326cd 100755
> --- a/t/t0006-date.sh
> +++ b/t/t0006-date.sh
> @@ -40,6 +40,8 @@ check_parse 2008-02 bad
>  check_parse 2008-02-14 bad
>  check_parse '2008-02-14 20:30:45' '2008-02-14 20:30:45 +0000'
>  check_parse '2008-02-14 20:30:45 -0500' '2008-02-14 20:30:45 -0500'
> +check_parse '2008-02-14 20:30:45 -05' '2008-02-14 20:30:45 -0500'
> +check_parse '2008-02-14 20:30:45 -05:00' '2008-02-14 20:30:45 -0500'
>  check_parse '2008-02-14 20:30:45' '2008-02-14 20:30:45 -0500' EST5
>
>  check_approxidate() {
>
> If I am reading your commit message correctly, that should work, right?
>

Yes, you are right. I will send an updated version to get this right.

Thank you for reviewing and giving suggestions!

/Haitao