From: Srujith Poojary <poojarysrujith@gmail.com>
Date: Thu, 29 Oct 2026 14:36:05 GMT
Subject: Re: [PATCH v3] [Outreachy PATCH] t0001: avoid pipes in test scripts
Message-ID: <CABh_KWik1x+CjVoTAywGLEeURVWj7u_TmWMsAwnma4g18MMoUg@mail.gmail.com>
In-Reply-To: <auM4FazXNNwLzM3-@pks.im>

On Thu, Oct 29, 2026 at 5:42 PM Patrick Steinhardt <ps@pks.im> wrote:
>
> On Fri, Oct 23, 2026 at 05:13:08AM +0000, Srujith A Poojary via GitGitGadget wrote:
> > From: Srujith Poojary <poojarysrujith@gmail.com>
> >
> > Avoid piping output from git version directly into sed to ensure
> >
> > that any command failure is properly caught by test scripts.
>
> Formatting of your commit message is off a bit with an empty line in
> the middle of the sentence.
>
> > diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> > index f1d227f271..c8c74f681b 100755
> > --- a/t/t0001-init.sh
> > +++ b/t/t0001-init.sh
> > @@ -678,7 +678,8 @@ test_expect_success 'default ref format' '
> >               sane_unset GIT_DEFAULT_REF_STORAGE_FORMAT &&
> >               git init refformat
> >       ) &&
> > -     git version --build-options | sed -ne "s/^default-ref-storage-format: //p" >expect &&
> > +     git version --build-options >build-options &&
> > +     sed -ne "s/^default-ref-storage-format: //p" build-options >expect &&
> >       git -C refformat rev-parse --show-ref-storage-format >actual &&
> >       test_cmp expect actual
> >  '
>
> The changes look good to me though. Thanks!
>
> Patrick

Hi Patrick,

Thank you for reviewing! Good catch—I've removed the empty line in the
commit message and submitted the updated version.

Best regards,
Srujith