From: Srujith Poojary Date: Sat, 31 Oct 2026 19:08:18 GMT Subject: Re: [PATCH] [Outreachy PATCH] t4041: use submodule repository for commit abbreviations Message-ID: In-Reply-To: On Sat, Oct 31, 2026 at 10:16 PM Okhuomon Ajayi wrote: > > Hi Srujith, > > I applied this on top of master and ran t4041. The new test fails > without the submodule.c change and passes with it, so it does catch > the problem. > > A few small things: > > On Sat, Oct 31, 2026 at 9:26 AM Srujith A Poojary via GitGitGadget > wrote: > > Use the submodule repository when abbreviating commit IDs in > > submodule diff headers, so uniqueness is checked against the > > correct object database. > > It would help to first describe what happens today: the commit IDs > in the "Submodule ..." header are abbreviated against the > superproject's objects, even though the commits live in the > submodule, so the abbreviation may not be unique there. > > > [Outreachy PATCH] t4041: use submodule repository for commit > > abbreviations > > The change itself is in submodule.c, so the title might read better > with that area, e.g. "submodule: use the submodule repository to > abbreviate commits". > > > - strbuf_add_unique_abbrev(&sb, one, DEFAULT_ABBREV); > > + if (sub) > > + strbuf_repo_add_unique_abbrev(&sb, sub, one, DEFAULT_ABBREV); > > + else > > + strbuf_add_unique_abbrev(&sb, one, DEFAULT_ABBREV); > > The same if/else appears twice. Maybe choose the repository once, > at the top of the function, and call strbuf_repo_add_unique_abbrev() > with it in both places. I also wonder whether the fallback could be > o->repo instead of the_repository, since the diff options already > carry a repository. > > Thanks, > Okhuomon Hi Okhuomon, Thanks for reviewing the patch and testing the new test case. I've made the suggested changes and submitted v2. I now use `sub` when available and fall back to `o->repo` when it isn't. I also simplified the code and updated the commit message. Here is the updated patch: https://lore.kernel.org/git/pull.2288.v2.git.1793473062113.gitgitgadget@gmail.com Thanks again! Regards, Srujith