From: Elijah Newren Date: Fri, 04 Feb 2022 20:01:22 GMT Subject: Re: [PATCH v6 0/3] completion: sparse-checkout updates Message-ID: In-Reply-To: On Fri, Feb 4, 2022 at 11:54 AM Junio C Hamano wrote: > > Elijah Newren writes: > > > Ævar had a good comment about code coverage on Windows that we might > > want to address first[1]. (Namely, splitting one test into two -- one > > that tests a path with backslashes that can be skipped on windows, and > > a separate test that checks paths with spaces, tabs, and non-ascii > > that can be run on all platforms.) > > According to the lazy-prereq definition for FUNNYNAMES, we seem to > skip tab-embedded names on windows, so it may not be used on all > platforms, but such a detail aside... > > I do not get why funny letters should matter and need to be tested > specially in the first place, to be honest, but because we have with > FUNNYNAMES prereq already, hiding some tests behind it would be a > good idea regardless. Earlier versions of the patch series failed to handle paths that contained various special characters; see the second comment at https://lore.kernel.org/git/CABPp-BEq9pTqsy_R_SR1DSgUK58ubNR1Gk4G1RoL8wkadyo6zw@mail.gmail.com/. Handling them was specifically the job of the third patch in the series, and thus it made sense to add some kind of test for them.