From: Elijah Newren <newren@gmail.com>
Date: Mon, 17 Nov 2025 19:52:03 GMT
Subject: Re: [PATCH v2 0/3] fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode>
Message-ID: <CABPp-BHY4SLmWY=V5aHJ6igN0GWeg6V1MoWDwszPe2O38wqBhw@mail.gmail.com>
In-Reply-To: <20251117043450.322644-1-christian.couder@gmail.com>

On Sun, Nov 16, 2025 at 8:35 PM Christian Couder
<christian.couder@gmail.com> wrote:
> There are no code changes in this v2, only commit message,
> documentation and test changes:
>
> * Rebased on current 'master'. This avoids the need to mark some
>   strings for translation as a recent series doing that has been
>   recently merged to 'master'.
>
> * In patch 3/3, improved the commit message to better justify the new
>   feature using some sentences from Elijah.
>
> * In patch 3/3, removed tests with dual signatures. This avoids a
>   conflict with a separate series from brian carlson that adds a
>   "RUST" prereq that is then needed to run tests with dual signatures.

I'm a bit surprised; from
https://lore.kernel.org/git/xmqqms4rry7f.fsf@gitster.g/, I thought you
were going to rearrange the tests to avoid the conflict, not delete
them.  Are no tests of this new functionality needed?

> * In patch 3/3, improved documentation of the new option to say that
>   validation behaves as the validation performed by `git
>   verify-commit`.

Looking over the range diff, the other changes look good.