From: Elijah Newren <newren@gmail.com>
Date: Tue, 16 Mar 2021 05:37:32 GMT
Subject: Re: [PATCH v3 0/9] read_tree() and read_tree_recursive() refactoring
Message-ID: <CABPp-BHWDffkqXsisp9E-FJPR4PmByPWuxWkAir24WpqUu43Lg@mail.gmail.com>
In-Reply-To: <20210315234344.28427-1-avarab@gmail.com>

On Mon, Mar 15, 2021 at 4:44 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
> A v3 of a refactoring of tree.c. See v2 at
> https://lore.kernel.org/git/20210308022138.28166-1-avarab@gmail.com/
>
> This brings back pretty much the old read_tree_recursive() under the
> name read_tree_at() as suggested in
> https://lore.kernel.org/git/xmqqft106sok.fsf@gitster.g/

Patch 8/9 was a bit harder for me to read; I'm not sure if that means
the patch needs improvement or just reflects a personal failing.  :-)
But ultimately, it's minor and the rest of the series looks good.
With or without a few tweaks to that patch:

Reviewed-by: Elijah Newren <newren@gmail.com>